consumer: fix consumeNum to respect consume timeout#1053
Open
katreniak wants to merge 3 commits intoBlizzard:masterfrom
Open
consumer: fix consumeNum to respect consume timeout#1053katreniak wants to merge 3 commits intoBlizzard:masterfrom
katreniak wants to merge 3 commits intoBlizzard:masterfrom
Conversation
One round poll to broker is needed to read the message. Second round poll to broker is needed to detect EOF. The test is asserting that we get message and EOF within 2s. But the consumer is configured with 'fetch.wait.max.ms': 1000. We don't fit 2 timout out polls within 2s. We need to increase the consume timeout to 3s.
One round poll to broker is needed to read the message. Second round poll to broker is needed to detect EOF. The test is asserting that we get EOF, data and EOF when data is produced at 2nd second. But the consumer is configured with 'fetch.wait.max.ms': 1000. We read the data in poll to broker slightly after 3rd second. We detect the 2nd EOF slightly after 4th second. We need to increase the consume timeout to 5s.
Steps to reproduce: * configure consumer with setDefaultConsumeTimeout(1000) * produce 1 message every 500ms * call consumer.consume(128, cb) Actual outcome: * consume returns 128 messages after 64 seconds Expected outcome: * consumer returns ~2 messages after 1 second KafkaConsumerConsumeNum call underlaying c++ m_consumer->Consume in cycle until * either the accumulated batch is full * or the call to c++ m_consumer->Consume times out on the total timeout KafkaConsumerConsumeNum must enforce its timeout over all m_consumer->Consume invocations altogether.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Steps to reproduce the problem:
setDefaultConsumeTimeout(1000)consumer.consume(128, cb)Actual outcome:
Expected outcome:
KafkaConsumerConsumeNum call underlaying c++
m_consumer->Consumein cycle until
KafkaConsumerConsumeNum must enforce its timeout
over all
m_consumer->Consumeinvocations altogether.